Fixed code review errors
This commit is contained in:
+19
-19
@@ -554,7 +554,7 @@ class GitHubTool(BaseTool):
|
|||||||
|
|
||||||
|
|
||||||
@metrics.measure
|
@metrics.measure
|
||||||
def execute(self, function_name, **kwargs):\
|
def execute(self, function_name, **kwargs):
|
||||||
self.logger.info(f"Executing: {function_name}")
|
self.logger.info(f"Executing: {function_name}")
|
||||||
|
|
||||||
if function_name == "read_file":
|
if function_name == "read_file":
|
||||||
@@ -708,7 +708,7 @@ class GitHubTool(BaseTool):
|
|||||||
self.logger.info(success_message)
|
self.logger.info(success_message)
|
||||||
return success_message
|
return success_message
|
||||||
else:
|
else:
|
||||||
error_message = f"Error committing file: {response.status_code}\\nResponse: {response.text}"
|
error_message = f"Error committing file: {response.status_code}\nResponse: {response.text}"
|
||||||
self.logger.error(error_message)
|
self.logger.error(error_message)
|
||||||
return error_message
|
return error_message
|
||||||
|
|
||||||
@@ -728,7 +728,7 @@ class GitHubTool(BaseTool):
|
|||||||
self.logger.info(success_message)
|
self.logger.info(success_message)
|
||||||
return success_message
|
return success_message
|
||||||
else:
|
else:
|
||||||
error_message = f"Error creating pull request: {response.status_code}\\nResponse: {response.text}"
|
error_message = f"Error creating pull request: {response.status_code}\nResponse: {response.text}"
|
||||||
self.logger.error(error_message)
|
self.logger.error(error_message)
|
||||||
return error_message
|
return error_message
|
||||||
|
|
||||||
@@ -860,7 +860,7 @@ class GitHubTool(BaseTool):
|
|||||||
self.logger.info(success_message)
|
self.logger.info(success_message)
|
||||||
return success_message
|
return success_message
|
||||||
else:
|
else:
|
||||||
error_message = f"Error approving pull request: {response.status_code}\\nResponse: {response.text}"
|
error_message = f"Error approving pull request: {response.status_code}\nResponse: {response.text}"
|
||||||
self.logger.error(error_message)
|
self.logger.error(error_message)
|
||||||
return error_message
|
return error_message
|
||||||
|
|
||||||
@@ -875,7 +875,7 @@ class GitHubTool(BaseTool):
|
|||||||
self.logger.info(success_message)
|
self.logger.info(success_message)
|
||||||
return success_message
|
return success_message
|
||||||
else:
|
else:
|
||||||
error_message = f"Error closing pull request: {response.status_code}\\nResponse: {response.text}"
|
error_message = f"Error closing pull request: {response.status_code}\nResponse: {response.text}"
|
||||||
self.logger.error(error_message)
|
self.logger.error(error_message)
|
||||||
return error_message
|
return error_message
|
||||||
|
|
||||||
@@ -890,7 +890,7 @@ class GitHubTool(BaseTool):
|
|||||||
self.logger.info(success_message)
|
self.logger.info(success_message)
|
||||||
return success_message
|
return success_message
|
||||||
else:
|
else:
|
||||||
error_message = f"Error merging pull request: {response.status_code}\\nResponse: {response.text}"
|
error_message = f"Error merging pull request: {response.status_code}\nResponse: {response.text}"
|
||||||
self.logger.error(error_message)
|
self.logger.error(error_message)
|
||||||
return error_message
|
return error_message
|
||||||
|
|
||||||
@@ -904,7 +904,7 @@ class GitHubTool(BaseTool):
|
|||||||
self.logger.info(success_message)
|
self.logger.info(success_message)
|
||||||
return success_message
|
return success_message
|
||||||
else:
|
else:
|
||||||
error_message = f"Error deleting branch: {response.status_code}\\nResponse: {response.text}"
|
error_message = f"Error deleting branch: {response.status_code}\nResponse: {response.text}"
|
||||||
self.logger.error(error_message)
|
self.logger.error(error_message)
|
||||||
return error_message
|
return error_message
|
||||||
@metrics.measure
|
@metrics.measure
|
||||||
@@ -928,7 +928,7 @@ class GitHubTool(BaseTool):
|
|||||||
self.logger.info(f"Successfully retrieved details for issue {issue_number}")
|
self.logger.info(f"Successfully retrieved details for issue {issue_number}")
|
||||||
return issue_details
|
return issue_details
|
||||||
else:
|
else:
|
||||||
error_message = f"Error getting issue details: {response.status_code}\\nResponse: {response.text}"
|
error_message = f"Error getting issue details: {response.status_code}\nResponse: {response.text}"
|
||||||
self.logger.error(error_message)
|
self.logger.error(error_message)
|
||||||
return error_message
|
return error_message
|
||||||
|
|
||||||
@@ -949,7 +949,7 @@ class GitHubTool(BaseTool):
|
|||||||
self.logger.info(success_message)
|
self.logger.info(success_message)
|
||||||
return success_message
|
return success_message
|
||||||
else:
|
else:
|
||||||
error_message = f"Error creating issue: {response.status_code}\\nResponse: {response.text}"
|
error_message = f"Error creating issue: {response.status_code}\nResponse: {response.text}"
|
||||||
self.logger.error(error_message)
|
self.logger.error(error_message)
|
||||||
return error_message
|
return error_message
|
||||||
|
|
||||||
@@ -974,7 +974,7 @@ class GitHubTool(BaseTool):
|
|||||||
self.logger.info(f"Successfully listed issues. Found {len(issues)} issues.")
|
self.logger.info(f"Successfully listed issues. Found {len(issues)} issues.")
|
||||||
return issues
|
return issues
|
||||||
else:
|
else:
|
||||||
error_message = f"Error listing issues: {response.status_code}\\nResponse: {response.text}"
|
error_message = f"Error listing issues: {response.status_code}\nResponse: {response.text}"
|
||||||
self.logger.error(error_message)
|
self.logger.error(error_message)
|
||||||
return error_message
|
return error_message
|
||||||
|
|
||||||
@@ -990,7 +990,7 @@ class GitHubTool(BaseTool):
|
|||||||
self.logger.info(success_message)
|
self.logger.info(success_message)
|
||||||
return success_message
|
return success_message
|
||||||
else:
|
else:
|
||||||
error_message = f"Error adding comment to issue: {response.status_code}\\nResponse: {response.text}"
|
error_message = f"Error adding comment to issue: {response.status_code}\nResponse: {response.text}"
|
||||||
self.logger.error(error_message)
|
self.logger.error(error_message)
|
||||||
return error_message
|
return error_message
|
||||||
|
|
||||||
@@ -1010,7 +1010,7 @@ class GitHubTool(BaseTool):
|
|||||||
self.logger.info(f"Successfully retrieved comments for issue {issue_number}. Found {len(comments)} comments.")
|
self.logger.info(f"Successfully retrieved comments for issue {issue_number}. Found {len(comments)} comments.")
|
||||||
return comments
|
return comments
|
||||||
else:
|
else:
|
||||||
error_message = f"Error getting issue comments: {response.status_code}\\nResponse: {response.text}"
|
error_message = f"Error getting issue comments: {response.status_code}\nResponse: {response.text}"
|
||||||
self.logger.error(error_message)
|
self.logger.error(error_message)
|
||||||
return error_message
|
return error_message
|
||||||
|
|
||||||
@@ -1136,7 +1136,7 @@ class GitHubTool(BaseTool):
|
|||||||
}
|
}
|
||||||
|
|
||||||
@metrics.measure
|
@metrics.measure
|
||||||
def _list_project_boards(self):\
|
def _list_project_boards(self):
|
||||||
self.logger.info("Fetching project boards...")
|
self.logger.info("Fetching project boards...")
|
||||||
url = f"{self.base_url}/repos/{self.repo}/projects"
|
url = f"{self.base_url}/repos/{self.repo}/projects"
|
||||||
response = requests.get(url, headers=self.headers)
|
response = requests.get(url, headers=self.headers)
|
||||||
@@ -1185,7 +1185,7 @@ class GitHubTool(BaseTool):
|
|||||||
self.logger.info(f"Successfully retrieved details for PR {pull_number}")
|
self.logger.info(f"Successfully retrieved details for PR {pull_number}")
|
||||||
return response.json()
|
return response.json()
|
||||||
else:
|
else:
|
||||||
error_message = f"Error getting pull request details: {response.status_code}\\nResponse: {response.text}"
|
error_message = f"Error getting pull request details: {response.status_code}\nResponse: {response.text}"
|
||||||
self.logger.error(error_message)
|
self.logger.error(error_message)
|
||||||
return error_message
|
return error_message
|
||||||
|
|
||||||
@@ -1200,7 +1200,7 @@ class GitHubTool(BaseTool):
|
|||||||
self.logger.info(f"Successfully retrieved diff for PR {pull_number}")
|
self.logger.info(f"Successfully retrieved diff for PR {pull_number}")
|
||||||
return response.text
|
return response.text
|
||||||
else:
|
else:
|
||||||
error_message = f"Error getting pull request diff: {response.status_code}\\nResponse: {response.text}"
|
error_message = f"Error getting pull request diff: {response.status_code}\nResponse: {response.text}"
|
||||||
self.logger.error(error_message)
|
self.logger.error(error_message)
|
||||||
return error_message
|
return error_message
|
||||||
|
|
||||||
@@ -1213,7 +1213,7 @@ class GitHubTool(BaseTool):
|
|||||||
self.logger.info(f"Successfully retrieved files for PR {pull_number}")
|
self.logger.info(f"Successfully retrieved files for PR {pull_number}")
|
||||||
return response.json()
|
return response.json()
|
||||||
else:
|
else:
|
||||||
error_message = f"Error getting pull request files: {response.status_code}\\nResponse: {response.text}"
|
error_message = f"Error getting pull request files: {response.status_code}\nResponse: {response.text}"
|
||||||
self.logger.error(error_message)
|
self.logger.error(error_message)
|
||||||
return error_message
|
return error_message
|
||||||
|
|
||||||
@@ -1239,7 +1239,7 @@ class GitHubTool(BaseTool):
|
|||||||
self.logger.info(success_message)
|
self.logger.info(success_message)
|
||||||
return success_message
|
return success_message
|
||||||
else:
|
else:
|
||||||
error_message = f"Error creating pull request review comment: {response.status_code}\\nResponse: {response.text}"
|
error_message = f"Error creating pull request review comment: {response.status_code}\nResponse: {response.text}"
|
||||||
self.logger.error(error_message)
|
self.logger.error(error_message)
|
||||||
return error_message
|
return error_message
|
||||||
|
|
||||||
@@ -1252,7 +1252,7 @@ class GitHubTool(BaseTool):
|
|||||||
self.logger.info(f"Successfully retrieved review comments for PR {pull_number}")
|
self.logger.info(f"Successfully retrieved review comments for PR {pull_number}")
|
||||||
return response.json()
|
return response.json()
|
||||||
else:
|
else:
|
||||||
error_message = f"Error listing pull request review comments: {response.status_code}\\nResponse: {response.text}"
|
error_message = f"Error listing pull request review comments: {response.status_code}\nResponse: {response.text}"
|
||||||
self.logger.error(error_message)
|
self.logger.error(error_message)
|
||||||
return error_message
|
return error_message
|
||||||
|
|
||||||
@@ -1269,6 +1269,6 @@ class GitHubTool(BaseTool):
|
|||||||
self.logger.info(success_message)
|
self.logger.info(success_message)
|
||||||
return success_message
|
return success_message
|
||||||
else:
|
else:
|
||||||
error_message = f"Error submitting pull request review: {response.status_code}\\nResponse: {response.text}"
|
error_message = f"Error submitting pull request review: {response.status_code}\nResponse: {response.text}"
|
||||||
self.logger.error(error_message)
|
self.logger.error(error_message)
|
||||||
return error_message
|
return error_message
|
||||||
|
|||||||
Reference in New Issue
Block a user